Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update audioplayers to ^6.0.0 in flame_audio #3158

Merged
merged 8 commits into from
May 22, 2024
Merged

chore: Update audioplayers to ^6.0.0 in flame_audio #3158

merged 8 commits into from
May 22, 2024

Conversation

ufrshubham
Copy link
Member

Description

This PR updates the audioplayers version for flame_audio.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #3151 and #3157

@spydon
Copy link
Member

spydon commented May 15, 2024

I thought there were some breaking changes we had to adhere to, but seemingly not? 🤔

@ufrshubham
Copy link
Member Author

I thought there were some breaking changes we had to adhere to, but seemingly not? 🤔

I didn't notice any breaking change in flame_audio, but I am getting some conflicts with multiple definitions of the Split class.

@spydon
Copy link
Member

spydon commented May 15, 2024

I thought there were some breaking changes we had to adhere to, but seemingly not? 🤔

I didn't notice any breaking change in flame_audio, but I am getting some conflicts with multiple definitions of the Split class.

Aaah right, that is due to the devtools extension, I'll migrate that when I get home from Google I/O (the name changed in the new version).

@ufrshubham ufrshubham changed the title chore: Update audioplayers constraint chore: Update sdk constraint to >=3.3.0 and audioplayers to ^6.0.0 May 15, 2024
@ufrshubham
Copy link
Member Author

Aaah right, that is due to the devtools extension, I'll migrate that when I get home from Google I/O (the name changed in the new version).

Okay, I'll leave it up to you then. I tried hiding the other definition but now it fails analyze saying Split is not exported.

spydon
spydon reviewed May 15, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dart SDK bump should probably preferably be done in a separate PR

@ufrshubham
Copy link
Member Author

Okay, I'll move that change into a separate PR tomorrow

@ufrshubham
Copy link
Member Author

Moved the dart sdk bump to #3160

@ufrshubham ufrshubham changed the title chore: Update sdk constraint to >=3.3.0 and audioplayers to ^6.0.0 chore: Update audioplayers to ^6.0.0 in flame_audio May 16, 2024
luanpotter
luanpotter approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ufrshubham ufrshubham merged commit 3d42a2c into main May 22, 2024
8 checks passed
@ufrshubham ufrshubham deleted the devkage/update_audioplayers_constraint branch May 22, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@renancaraujo renancaraujo renancaraujo approved these changes

@luanpotter luanpotter luanpotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update flame_audio to support audioplayers:^6.0.0
4 participants
@ufrshubham @spydon @luanpotter @renancaraujo